Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-1510

Several SAML bugs: mapping bugs, identityId paramter issues, wrong error messages and some typos

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • 1.9.5
    • Auth: SAML
    • None
    • MOODLE_19_STABLE

      This patch solves some bugs:

      • Fix the SimpleSAMLPHP Library path. /home/simplesaml/lib instead of /home/simplesaml.

      In the implementation the web configurator plugin ask for the library path but it actually needs the simplesaml path. I made some minor changes in order to use the SimpleSAMLPHP Library path.

      • Fix the identityId= , when there is no entity id in the configuration, the plugin shouldn't construct a url with a identityId parameter.

      In the actual implementation if admin don't set an Entity id, then the plugin construct an url with an empty identityId= that simplesamlphp can't handle. To fix this the url should not contains the identityid parameter so simplesamlphp would use the idpdiscovery instead of generating an error.

      • Fix mapping bugs.

      When the name of the fields for the mapping aren't correct, the plugin return a white page (due to an error) or prints an "authentication plugin not found" error message. The patch fixes this by ignoring any mapping error except the username mapping since that is required. When the username mapping fails an specific error will be shown: 'IdP returned a set of data that no contain the SAML username mapping field. This field is required to login'

      • Fix some typos. Example. In config.hml #28 $config->userame = 'mail'; should be $config->username = 'mail';

      I hope you find the patch useful and we can see it commited upstream. Feel free to mail me if you need some help to implement new features.

      Best regards

            piers Piers Harding (Inactive)
            smartin_yaco Sixto Martin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.