diff --git a/mod/forum/tests/externallib_test.php b/mod/forum/tests/externallib_test.php index 6b3445e45f7..ff21674ce0a 100644 --- a/mod/forum/tests/externallib_test.php +++ b/mod/forum/tests/externallib_test.php @@ -2609,7 +2609,6 @@ class mod_forum_external_testcase extends externallib_advanced_testcase { * Test get forum posts by user id. */ public function test_mod_forum_get_discussion_posts_by_userid() { - global $DB; $this->resetAfterTest(true); $urlfactory = mod_forum\local\container::get_url_factory(); @@ -2660,12 +2659,15 @@ class mod_forum_external_testcase extends externallib_advanced_testcase { $forum1 = self::getDataGenerator()->create_module('forum', $record); $forum1context = context_module::instance($forum1->cmid); + $time = time(); // Add discussions to the forums. $record = new stdClass(); $record->course = $course1->id; $record->userid = $user1->id; $record->forum = $forum1->id; $record->timemodified = 1; + $record->timestart = $time - 200; + $record->timeend = $time - 100; $discussion1 = $forumgenerator->create_discussion($record); $discussion1firstpost = $postvault->get_first_post_for_discussion_ids([$discussion1->id]); $discussion1firstpost = $discussion1firstpost[$discussion1->firstpost]; @@ -2676,6 +2678,8 @@ class mod_forum_external_testcase extends externallib_advanced_testcase { $record->userid = $user1->id; $record->forum = $forum1->id; $record->timemodified = 2; + $record->timestart = $time - 200; + $record->timeend = $time - 100; $discussion2 = $forumgenerator->create_discussion($record); $discussion2firstpost = $postvault->get_first_post_for_discussion_ids([$discussion2->id]); $discussion2firstpost = $discussion2firstpost[$discussion2->firstpost]; @@ -2723,18 +2727,6 @@ class mod_forum_external_testcase extends externallib_advanced_testcase { // So the user automatically gets mod/forum:viewdiscussion on all forums of the course. $this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'teacher'); $this->getDataGenerator()->enrol_user($user2->id, $course1->id); - // Changed display period for the discussions in past. - $time = time(); - $discussion = new \stdClass(); - $discussion->id = $discussion1->id; - $discussion->timestart = $time - 200; - $discussion->timeend = $time - 100; - $DB->update_record('forum_discussions', $discussion); - $discussion = new \stdClass(); - $discussion->id = $discussion2->id; - $discussion->timestart = $time - 200; - $discussion->timeend = $time - 100; - $DB->update_record('forum_discussions', $discussion); // Create what we expect to be returned when querying the discussion. $expectedposts = array( 'discussions' => array(),