From 6fa426eea0246d9ec55396009af1b6d2043b418a Mon Sep 17 00:00:00 2001 From: Fergus Whyte Date: Wed, 22 May 2013 09:34:47 +1200 Subject: [PATCH] MDL-39692 grade: Fixed deleting letter boundries for grades --- grade/edit/letter/index.php | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/grade/edit/letter/index.php b/grade/edit/letter/index.php index d0dc35a..01518bb 100644 --- a/grade/edit/letter/index.php +++ b/grade/edit/letter/index.php @@ -151,27 +151,15 @@ if (!$edit) { } krsort($letters, SORT_NUMERIC); - $old_ids = array(); - if ($records = $DB->get_records('grade_letters', array('contextid' => $context->id), 'lowerboundary ASC', 'id')) { - $old_ids = array_keys($records); - } - + $DB->delete_records('grade_letters', array('contextid' => $context->id)); + foreach($letters as $boundary=>$letter) { $record = new stdClass(); $record->letter = $letter; $record->lowerboundary = $boundary; $record->contextid = $context->id; - if ($old_id = array_pop($old_ids)) { - $record->id = $old_id; - $DB->update_record('grade_letters', $record); - } else { - $DB->insert_record('grade_letters', $record); - } - } - - foreach($old_ids as $old_id) { - $DB->delete_records('grade_letters', array('id' => $old_id)); + $DB->insert_record('grade_letters', $record); } redirect($returnurl); -- 1.8.1.msysgit.1