From 31f5a7fb1a0f3acb3663474918e64511f639d51d Mon Sep 17 00:00:00 2001
From: Paul Nicholls <paul.nicholls@canterbury.ac.nz>
Date: Wed, 7 Jul 2010 11:14:23 +1200
Subject: [PATCH] MDL-22903 - "Groupings" and "Overview" tabs broken on Groups page

---
 group/groupings.php   |    2 +-
 group/overview.php    |    2 +-
 lib/navigationlib.php |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/group/groupings.php b/group/groupings.php
index 468febe..4ab4ffa 100644
--- a/group/groupings.php
+++ b/group/groupings.php
@@ -50,7 +50,7 @@ $struses         = get_string('activities');
 $strparticipants = get_string('participants');
 $strmanagegrping = get_String('showgroupsingrouping', 'group');
 
-$PAGE->settingsnav->get('courseadmin')->get('groups')->make_active();
+$PAGE->settingsnav->get('courseadmin')->find('groups', navigation_node::TYPE_SETTING)->make_active();
 $PAGE->navbar->add($strgroupings);
 
 /// Print header
diff --git a/group/overview.php b/group/overview.php
index 85149ea..c605124 100644
--- a/group/overview.php
+++ b/group/overview.php
@@ -100,7 +100,7 @@ if ($rs = $DB->get_recordset_sql($sql, $params)) {
     $rs->close();
 }
 
-$PAGE->settingsnav->get('courseadmin')->get('groups')->make_active();
+$PAGE->settingsnav->get('courseadmin')->find('groups', navigation_node::TYPE_SETTING)->make_active();
 $PAGE->navbar->add(get_string('overview', 'group'));
 
 /// Print header
diff --git a/lib/navigationlib.php b/lib/navigationlib.php
index 7e5c9ca..4e060f3 100644
--- a/lib/navigationlib.php
+++ b/lib/navigationlib.php
@@ -710,7 +710,7 @@ class navigation_node_collection implements IteratorAggregate {
             $nodes = $this->getIterator();
             // Search immediate children first
             foreach ($nodes as &$node) {
-                if ($node->key == $key && ($type == null || $type === $node->type)) {
+                if ($node->key === $key && ($type == null || $type === $node->type)) {
                     return $node;
                 }
             }
-- 
1.7.0.2.msysgit.0