From 63a59d5a0c0d33288f8c069146f5a0d3bebe28c3 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Wed, 3 Apr 2024 22:51:39 +0800 Subject: [PATCH 1/1] MDL-79863 CPP @var fix --- question/type/ordering/classes/output/feedback.php | 6 +++++- .../ordering/classes/output/formulation_and_controls.php | 7 +++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/question/type/ordering/classes/output/feedback.php b/question/type/ordering/classes/output/feedback.php index 962fdcb4df..875ed785fd 100644 --- a/question/type/ordering/classes/output/feedback.php +++ b/question/type/ordering/classes/output/feedback.php @@ -36,7 +36,11 @@ class feedback extends renderable_base { * @param question_display_options $options Controls what should and should not be displayed * via question_display_options but unit tests are fickle. */ - public function __construct(question_attempt $qa, protected question_display_options $options) { + public function __construct( + question_attempt $qa, + /** @var question_display_options The question options. */ + protected question_display_options $options, + ) { parent::__construct($qa); } diff --git a/question/type/ordering/classes/output/formulation_and_controls.php b/question/type/ordering/classes/output/formulation_and_controls.php index 1f7e9b25a8..08682ef9c2 100644 --- a/question/type/ordering/classes/output/formulation_and_controls.php +++ b/question/type/ordering/classes/output/formulation_and_controls.php @@ -27,14 +27,17 @@ use question_display_options; * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ class formulation_and_controls extends renderable_base { - /** * Construct the rendarable as we also need to pass the question options. * * @param question_attempt $qa The question attempt object. * @param question_display_options $options The question options. */ - public function __construct(question_attempt $qa, protected question_display_options $options) { + public function __construct( + question_attempt $qa, + /** @var question_display_options The question options. */ + protected question_display_options $options, + ) { parent::__construct($qa); } -- 2.42.0